View on GitHub

DIALS // knowledgebase

community resources, howtos, meeting minutes

DIALS core meeting 2020-12-09

Previous Actions


This meeting instance is ring-fenced to discuss pull requests with the word ‘range’ and/or ‘lazy’ in the subject, and performance issues baked into dxtbx.

Definition of trusted_range

Discuss PR Definition of trusted_range (dxtbx#182)

image_range vs. array_range baked in off-by-one errors

Discuss image_range vs. array_range baked in off-by-one errors (dxtbx#186)

dxtbx json/msgpack performance

ASB reports json being problematic when importing e.g. 50,000 experiments, as everything is stored in a single file, so everything needs to be read at once.

Previous discussion outcomes:

GW dump of thoughts on above

Long list of pertinent (and unresolved) issues indicates we probably have some rather fundamental work to do here. This will boil down to essentially a dx2bx which would have some features listed below.

Smaller issues which could still be fixed “properly”

dx2bx features:

This is likely to be a big body of work but I think is on the critical path for what we need to do.


Features of dxtbx we want to preserve in a re-write:

Things that should go away

New features that are desired

Conclusion of discussion: consensus was to take this forward to a project proposal to active collaborators, with an explicit rename such that dxtbx continues along it’s existing path for non-DIALS users.

Deferred Agenda Items

Aaron’s PR Requests

Aaron requested that a slew of pull requests be reviewed by the next meeting after 2020-11-25:



renaming master branch → main

not discussed in this meeting

DIALS documentation build

not discussed in this meeting

Should the DIALS documentation build outside a cctbx environment?

move the active dxtbx repository into the DIALS organisation

not discussed in this meeting

Having the main repository in cctbx_project has a few distinct disadvantages. The most annoying is the eternal fight against the lockdown bot, but we also don’t get LGTM output.

dials.index: create new experiments

not discussed in this meeting

dials.index should (or should not) create new experiments with crystals in rather than modifying in place existing experiments as proposed in this issue

Next meeting

Thursday, January 14th, 4pm UK time, 8am PDT.